feat: Lazy Infra Creation with online_store Option Set to True #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zabarn
changed the title
msistla96
requested changes
Oct 16, 2024
EXPEbdodla
reviewed
Oct 19, 2024
| @@ -153,6 +153,12 @@ class CassandraOnlineStoreConfig(FeastConfigBaseModel): | |||
| request_timeout: Optional[StrictFloat] = None | |||
| """Request timeout in seconds.""" | |||
|
|
|||
| ttl: Optional[StrictInt] = None | |||
There was a problem hiding this comment.
We can set this to 0. ttl is discouraged due to tombstones. If users need it, they can set which comes with extra load on the cluster.
There was a problem hiding this comment.
Will handle ttl in a separate PR.
EXPEbdodla
reviewed
Oct 19, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Oct 19, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Oct 19, 2024
| @@ -88,7 +88,7 @@ | |||
| event_ts TIMESTAMP, | |||
| created_ts TIMESTAMP, | |||
| PRIMARY KEY ((entity_key), feature_name) | |||
| ) WITH CLUSTERING ORDER BY (feature_name ASC); | |||
| ) WITH CLUSTERING ORDER BY (feature_name ASC) {optional_ttl_clause}; | |||
There was a problem hiding this comment.
We can change to WITH default_time_to_live = {ttl}
There was a problem hiding this comment.
Will handle ttl in a separate PR.
EXPEbdodla
reviewed
Oct 19, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Oct 19, 2024
| statement = template.format( | ||
| fqtable=fqtable, | ||
| **kwargs, | ||
| fqtable=fqtable, optional_ttl_clause=ttl_clause, **kwargs |
There was a problem hiding this comment.
just pass the ttl value directly.
There was a problem hiding this comment.
Will handle ttl in a separate PR.
EXPEbdodla
reviewed
Oct 19, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
EXPEbdodla
reviewed
Oct 19, 2024
EXPEbdodla
reviewed
Oct 19, 2024
EXPEbdodla
reviewed
Oct 19, 2024
EXPEbdodla
reviewed
Oct 22, 2024
sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/cassandra_online_store.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is includes the addition of
lazy_table_creationtoCassandraOnlineStoreConfig.lazy_table_creationis used infeature_story.py'sapplymethod to defer infra creation to the Materialization stage, found in this PR: #147.Which issue(s) this PR fixes:
https://jira.expedia.biz/browse/EAPC-14919
Misc